Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Invalid XML response #9191

Closed
wants to merge 1 commit into from
Closed

fix: Invalid XML response #9191

wants to merge 1 commit into from

Conversation

neznaika0
Copy link
Contributor

Description
I don't understand why this is not detected on github, but there is a bug in the local environment.
Perhaps the cache is interfering here
Replace to <false></false>:

1) CodeIgniter\Test\FeatureTestTraitTest::testSetupRequestBodyWithXml
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 '<?xml version="1.0"?>
-<response><true>1</true><false/><int>2</int><null/><float>1.23</float><string>foo</string></response>
+<response><true>1</true><false></false><int>2</int><null></null><float>1.23</float><string>foo</string></response>
 '

@kenjis kenjis added the testing Pull requests that changes tests only label Sep 15, 2024
@kenjis
Copy link
Member

kenjis commented Sep 15, 2024

See https://github.com/codeigniter4/CodeIgniter4/actions/runs/10860683361/job/30141629888?pr=9191

@kenjis
Copy link
Member

kenjis commented Sep 15, 2024

<false/> is correct.

@kenjis kenjis closed this Sep 15, 2024
@kenjis
Copy link
Member

kenjis commented Sep 15, 2024

Your library linked to PHP (libxml) is old?

@neznaika0
Copy link
Contributor Author

Maybe. I am using Debian Testing, php 8.3.9
My tests are not running on the local PC. I wanted to correct it. Apparently, you will never achieve the perfect environment (without docker)

@neznaika0 neznaika0 deleted the fix-xml-response-test branch September 15, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neznaika0 @kenjis